This repository has been archived by the owner on May 4, 2024. It is now read-only.
[package] Allow bytecode version to be set from input #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, the bytecode version can only be set by environment variable, which is a bit messy. This ensures that the input can be set from other ways than just the environment variable.
gregnazario
force-pushed
the
allow-cli-input-bytecode-version
branch
from
fae6315
to
727a1e2
Compare
wrwg
approved these changes
Feb 23, 2023
gregnazario
added a commit
that referenced
this pull request
Mar 7, 2023
Right now, the bytecode version can only be set by environment variable, which is a bit messy. This ensures that the input can be set from other ways than just the environment variable.
gregnazario
added a commit
that referenced
this pull request
Mar 9, 2023
Right now, the bytecode version can only be set by environment variable, which is a bit messy. This ensures that the input can be set from other ways than just the environment variable.
gregnazario
added a commit
that referenced
this pull request
Mar 9, 2023
Right now, the bytecode version can only be set by environment variable, which is a bit messy. This ensures that the input can be set from other ways than just the environment variable.
gregnazario
added a commit
that referenced
this pull request
Mar 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Right now, the bytecode version can only be set by environment variable, which is a bit messy. This ensures that the input can be set from other ways than just the environment variable.
Have you read the Contributing Guidelines on pull requests?
Yes
Test Plan
Already existing tests